Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove force exit from web3-eth tests #7398

Draft
wants to merge 2 commits into
base: 4.x
Choose a base branch
from
Draft

Conversation

krzysu
Copy link
Contributor

@krzysu krzysu commented Nov 18, 2024

Fixes #7230

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 649.08 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 630.33 kB 0%
../lib/commonjs/index.d.ts 8.72 kB 0%
../lib/commonjs/accounts.d.ts 3.06 kB 0%
../lib/commonjs/types.d.ts 2.73 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.28 kB 0%
../lib/commonjs/abi.d.ts 1.06 kB 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: c820198 Previous: 1b367e6 Ratio
processingTx 22964 ops/sec (±7.51%) 22803 ops/sec (±7.61%) 0.99
processingContractDeploy 41239 ops/sec (±6.97%) 39134 ops/sec (±6.74%) 0.95
processingContractMethodSend 16898 ops/sec (±7.10%) 15697 ops/sec (±6.86%) 0.93
processingContractMethodCall 27789 ops/sec (±6.80%) 28086 ops/sec (±6.28%) 1.01
abiEncode 43413 ops/sec (±10.57%) 44672 ops/sec (±6.81%) 1.03
abiDecode 30578 ops/sec (±7.54%) 30809 ops/sec (±8.27%) 1.01
sign 1527 ops/sec (±0.57%) 1511 ops/sec (±3.64%) 0.99
verify 361 ops/sec (±0.57%) 366 ops/sec (±0.54%) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.51%. Comparing base (1b367e6) to head (c820198).

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7398   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files         218      218           
  Lines        8557     8557           
  Branches     2363     2363           
=======================================
  Hits         8088     8088           
  Misses        469      469           
Flag Coverage Δ
UnitTests 94.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

"test:e2e:mainnet": "jest --config=./test/e2e/jest.config.js --forceExit",
"test:e2e:sepolia": "jest --config=./test/e2e/jest.config.js --forceExit",
"test:e2e:mainnet": "jest --config=./test/e2e/jest.config.js",
"test:e2e:sepolia": "jest --config=./test/e2e/jest.config.js",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luu-alex @jdevcs these tests from web3-eth package seems to be always skipped, even in the release builds, maybe we should just delete them altogether? ie. see https://github.com/web3/web3.js/actions/runs/11710089473/job/32616617212

> web3-eth:"test:e2e:sepolia"

$ jest --config=./test/e2e/jest.config.js --forceExit

Test Suites: 1 skipped, 0 of 1 total
Tests:       1 skipped, 1 total

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web3-eth tests update/fixes
1 participant