-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: error description+refactoring #841
chore: error description+refactoring #841
Conversation
performed refactoring of APIRequests+Methods.swift, ENSBaseRegistrar, ENSRegistry, ENSResolver, ENSReverseRegistrar, ETHRegistrarController,
} | ||
|
||
internal init(urlSession: URLSessionProxy, apiKey: String) { | ||
self.urlSession = urlSession | ||
self.apiKey = apiKey | ||
self.apiKey = apiKey.trim() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd purpose to switch all such string functions as a properties. e.g. apiKey.trimed
, function.selector.hexPrefixAdded.lowercased
. I mean to add such as a separate issue for further work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not mind but what is the benefit or reason for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way it would better fits with clean code rules. Actually this way it wouldn't violates the rule of in-depth abstraction layers mixing as it is with chain function calls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be handled in a separate PR.
The merge-base changed after approval.
I'd purpose to switch all such string functions as a properties. e.g. |
@yaroslavyaroslav I'll update the codebase to this style in a separate PR so there's no need to re-review this one. |
Note
Before starting the review of this PR make sure the following is merged: #839
Summary of Changes
By submitting this pull request, you are confirming the following:
develop
branch.