Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unecessary DOM elements in the lib #132

Merged
merged 7 commits into from
Mar 11, 2022
Merged

Remove unecessary DOM elements in the lib #132

merged 7 commits into from
Mar 11, 2022

Conversation

kalwalt
Copy link
Member

@kalwalt kalwalt commented Mar 10, 2022

Removing DOM code

My initial idea was to make the code node.js compliant as said in #128 but it's not as simple as removing only DOM code. There are other part that the code fails to load in a node environment. I will do in another PR, i prefer to make by little steps.

Tasks done

  • removed canvas, cts, image, orientation properties from artoolkitNFT.api.js and ARControllerNFT.ts
  • fixed qunit test

@kalwalt kalwalt self-assigned this Mar 10, 2022
@kalwalt
Copy link
Member Author

kalwalt commented Mar 10, 2022

CI test fails because i removed canvas, ctx and other properties from ARControllerNFT. i will fix the test.js code.

@kalwalt kalwalt merged commit 1476e50 into dev Mar 11, 2022
@kalwalt kalwalt deleted the remove-DOM-elements branch March 22, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant