This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
Refactors code. State is now reflected via icon (color/greyscale) and title (number of web components). #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… title (number of web components). Actually I wanted to add the greyscale icon. Now the code is completely refactored. The background script is reduced to communicated with the pageAction icon. The content script is set up to be extendable. Styles are applied via classes and can be switched on/off by setting one trigger class to the html element.
|
Wasn't meant to be that much change when I forked, feel free to reject if it is too much.. |
|
Hey @lrsjng, that's a big rewrite. I like the idea of the greyscale icon and applying the styles via classes, although I didn't want to do that in the first place because of an extra HTTP request. If you could separate what matters into small commits that would be much easier to review. |
|
@zenorocha I'm afraid breaking it down into smaller patches won't be possible. There are no incremental steps to update this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually I wanted to add the greyscale icon. Now the code is completely refactored.
The background script is reduced to communicated with the pageAction icon.
The content script is set up to be extendable. Styles are applied via classes and can
be switched on/off by setting one trigger class to the html element.