-
Notifications
You must be signed in to change notification settings - Fork 21
Let v4 support w3c drivers #32
base: master
Are you sure you want to change the base?
Conversation
* Add w3c capabilities to the session command to let w3c drivers work correctly.
|
How has this been tested? One which browsers has this been tested in? |
desiredCapabilities: this.desiredCapabilities | ||
}) | ||
const jsonwpCaps = this.desiredCapabilities; | ||
const w3cCapKeys = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These don't match what exists in webdriver v5:
https://github.com/webdriverio/webdriverio/blob/e79328564e049fe6c81f0319ffe89d9293462e69/packages/webdriverio/src/constants.js#L369
looking at goog:chromeOptions
and moz:firefoxOptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emilyrohrbough goog:chromeOptions
and moz:firefoxOptions
are valid w3c browser specific options.
See https://www.w3.org/TR/webdriver1/#dfn-extension-capability, https://developer.mozilla.org/en-US/docs/Web/WebDriver/Capabilities.
@emilyrohrbough Sure, I'll add some tests later. |
@shinxi I highly recommend to switch to v5 because v4 (even with this patch) is not 100% compatible with the WebDriver spec. You will end up spending more time fixing those kind of issues than rewriting your test suite into v5. |
Reference: webdriverio/webdriverio#4380
Proposed changes
Types of changes
Checklist
Further comments
Reviewers: @christian-bromann