Update String helper:

- add shortTag parameter
webeweb · Mar 11, 2020 · bbc70b4 · bbc70b4
1 parent f272561
commit bbc70b4
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/src/Argument/Helper/StringHelper.php b/src/Argument/Helper/StringHelper.php
@@ -28,9 +28,10 @@ class StringHelper {
      * @param string $name The name.
      * @param string $value The value.
      * @param array $attributes The attributes.
+     * @param bool $shortTag Short tag ?
      * @return string Returns the DOM node.
      */
-    public static function domNode($name, $value, array $attributes = []) {
+    public static function domNode($name, $value, array $attributes = [], $shortTag = false) {
 
         $template = "<%name%%attributes%>%text%</%name%>";
 
@@ -40,6 +41,9 @@ public static function domNode($name, $value, array $attributes = []) {
         }
 
         $text = null !== $value ? trim($value, " ") : "";
+        if ("" === $text && true === $shortTag) {
+            $template = str_replace(">%text%</%name%>", "/>", $template);
+        }
 
         return str_replace(["%name%", "%attributes%", "%text%"], [trim($name), $attr, $text], $template);
     }

diff --git a/tests/Argument/Helper/StringHelperTest.php b/tests/Argument/Helper/StringHelperTest.php
@@ -15,7 +15,7 @@
 use WBW\Library\Core\Tests\AbstractTestCase;
 
 /**
- * String utility test.
+ * String helper test.
  *
  * @author webeweb <https://github.com/webeweb/>
  * @package WBW\Library\Core\Tests\Argument\Helper
@@ -34,6 +34,18 @@ public function testDomNode() {
         $this->assertEquals($res, StringHelper::domNode("script", "\n    $(document).ready(function() {});\n", $arg) . "\n");
     }
 
+    /**
+     * Tests the domNode() method.
+     *
+     * @return void
+     */
+    public function testDomNodeWithShortTag() {
+
+        $arg = ["type" => "text/javascript"];
+        $res = '<script type="text/javascript"/>';
+        $this->assertEquals($res, StringHelper::domNode("script", null, $arg, true));
+    }
+
     /**
      * Tests the parseArray() method.
      *