Remove WGPUAdapterProperties/wgpuAdapterGetProperties #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainino0x
approved these changes
Jun 12, 2024
kainino0x
approved these changes
Jun 12, 2024
|
Thanks! |
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Jun 14, 2024
Following up on a webgpu.h change[1], this CL adds support for adapter properties memory heaps, adapter properties D3D, adapter properties vk, dawn adapter properties power preference, and compatibility mode to GPUAdapter GetInfo() method so that Chrome can start the migration[2]. Once done, the GPUAdapter GetProperties() method will be marked as deprecated and we'll start using only GetInfo() in Dawn. Finally, we'll remove the GPUAdapter GetProperties() method. [1]: webgpu-native/webgpu-headers#305 [2]: https://chromium-review.googlesource.com/c/chromium/src/+/5626172 Bug: 335383516 Change-Id: I720581c1c5594d8997dc794e228fe14efb8d20cd Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/193461 Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org>
hubot
pushed a commit
to google/skia
that referenced
this pull request
Jun 17, 2024
This CL makes sure Skia uses GPUAdapter GetInfo() instead of GetProperties() so that we can start removing GetProperties() in Dawn following on webgpu.h change[1]. [1]: webgpu-native/webgpu-headers#305 Bug: 335383516 Change-Id: Ifb416c6e8f738fd81b0fb705ff0d19381017c0ef Reviewed-on: https://skia-review.googlesource.com/c/skia/+/866796 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As raised in #266 (comment), this PR removes WGPUAdapterProperties/wgpuAdapterGetProperties. The new wgpuAdapterGetInfo replaces both wgpuAdapterRequestAdapterInfo and wgpuAdapterGetProperties (that's why we added the vendor/device ID to the struct).
FIX #266