Fix: Drop mime-db dependency for http-compression rule
#1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mime-db` was used as a source to check if something should be compressed, but the project is planning to drop the `compressible` data in the near future in favor of the `compressible`¹ project. All of the cases currently covered by `compressible` are already covered by our code, so this change just adds the cases that were covered by `mime-db` and not by our code, hence, maintaining backwards compatibility. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - ¹ https://github.com/jshttp/compressible Fix #1108
alrra
changed the title
mime-db dependencymime-db dependency for http-compression rule
|
@alrra shouldn't this be a chore because nothing changes to the end user? |
It should, but I wanted to trigger a new release. Also, this is in some cases is a performance improvement, since we no longer need to query |
sarvaje
approved these changes
Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Make sure you:
For non-trivial changes, please make sure you also:
Short description of the change(s)
mime-dbwas used as a source to check if something should be compressed, but the project is planning to drop thecompressibledata in the near future in favor of thecompressibleproject.All of the cases currently covered by
compressibleare already covered by our code, so this change just adds the cases that were covered bymime-dband not by our code, hence, maintaining backwards compatibility.Fix: #1108