-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds JPEG XL support, max_height/max_width support #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
n0vad3v
changed the title
WIP: Adds JPEG XL support, max_height/max_width support
Adds JPEG XL support, max_height/max_width support
Mar 15, 2024
BennyThink
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's merge it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR contains the following changes:
Changes
jxl
indebian
is still in old version 0.7.0, we need 0.10.0+, some references on new version of JXL here: https://cloudinary.com/blog/jpeg-xl-and-the-pareto-frontmax_height
andmax_width
parameters, fills the need in set maxWidth and/or maxHeight #305Config file changes
ENABLE_AVIF
support and change to"CONVERT_TYPES": ["webp","avif","jxl"],
to specify wanted convert typesIMG_PATH
to fully migrate toIMG_MAP
formatSTRIP_METADATA
defaults to trueSTRIP_METADATA
For the
config.json
part, the newconfig.json
will be in the following format:Note:
STRIP_METADATA
,CONVERT_TYPES
are newly added,ENABLE_AVIF
is removed.