Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds JPEG XL support, max_height/max_width support #321

Merged
merged 18 commits into from
Mar 22, 2024
Merged

Conversation

n0vad3v
Copy link
Member

@n0vad3v n0vad3v commented Mar 11, 2024

This is PR contains the following changes:

Changes

Config file changes

  • Config update, drops ENABLE_AVIF support and change to "CONVERT_TYPES": ["webp","avif","jxl"], to specify wanted convert types
  • Config update, planning to drop support for IMG_PATH to fully migrate to IMG_MAP format
  • Config update, added STRIP_METADATA defaults to true
  • Fix: original image's metadata should be removed on STRIP_METADATA

For the config.json part, the new config.json will be in the following format:

{
  "HOST": "127.0.0.1",
  "PORT": "3333",
  "QUALITY": "80",
  "IMG_PATH": "./pics",
  "EXHAUST_PATH": "./exhaust",
  "IMG_MAP": {},
  "ALLOWED_TYPES": ["jpg","png","jpeg","bmp","svg","heic","nef"],
  "CONVERT_TYPES": ["webp","avif","jxl"],
  "STRIP_METADATA": true,
  "ENABLE_EXTRA_PARAMS": false
  "READ_BUFFER_SIZE": 4096,
  "CONCURRENCY": 262144,
  "DISABLE_KEEPALIVE": false,
  "CACHE_TTL": 259200,
}

Note: STRIP_METADATA, CONVERT_TYPES are newly added, ENABLE_AVIF is removed.

Copy link


ghcr.io/webp-sh/webp_server_go (debian 12.5)
============================================
Total: 0 (HIGH: 0, CRITICAL: 0)


@n0vad3v n0vad3v marked this pull request as ready for review March 15, 2024 12:47
@n0vad3v n0vad3v changed the title WIP: Adds JPEG XL support, max_height/max_width support Adds JPEG XL support, max_height/max_width support Mar 15, 2024
Copy link
Member

@BennyThink BennyThink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge it!

encoder/encoder.go Outdated Show resolved Hide resolved
encoder/encoder.go Outdated Show resolved Hide resolved
helper/helper.go Outdated Show resolved Hide resolved
@n0vad3v n0vad3v merged commit 43c275e into master Mar 22, 2024
5 checks passed
@n0vad3v n0vad3v deleted the jxl-params branch March 22, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants