Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: never proxy hot-reload websocket requests #4316

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ajhyndman
Copy link

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Please let me know what kind of test could be appropriate for this change.

Motivation / Use-Case

Both create-react-app and vue-cli-service have introduced workarounds for this, but it seems to me that this is always desirable behaviour for webpack-dev-server.

vuejs/vue-cli@72ba750
facebook/create-react-app#7444

Both create-react-app and vue-cli-service have introduced workarounds for this, but it seems to me that this is always desirable behaviour for webpack-dev-server.

vuejs/vue-cli@72ba750
facebook/create-react-app#7444
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 27, 2022

CLA Signed

The committers are authorized under a signed CLA.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add test case and fix types?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants