Move org storage recalculation into background job #2138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikreymer
approved these changes
Nov 19, 2024
ikreymer
reviewed
Nov 19, 2024
ikreymer
reviewed
Nov 19, 2024
| oid, backend_image, pull_policy, job_id, job_type=BgJobType.DELETE_ORG.value | ||
| ) | ||
|
|
||
| async def run_recalculate_org_stats_job( |
There was a problem hiding this comment.
I wonder if we should perhaps make a more generic run_bg_job here if most of the params are the same - but can be added in a later refactor as we add more jobs, so shouldn't hold off merge.
There was a problem hiding this comment.
Oh I see, I guess there already is a more generic method, maybe not needed at all, we'll see!
There was a problem hiding this comment.
Yes there's a generic private method already, the public methods here really just set the job id to what we want it to be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2112
Not moving org import over to a background job yet as we hadn't firmly decided to do that and it seems likely to take more time to figure out mounting the JSON to import into the background job container than I wanted to spend on this for this sprint.