refactor api

rtc-sdp/Cargo.toml

@@ -10,10 +10,10 @@ homepage = "https://webrtc.rs"
 repository = "https://github.com/webrtc-rs/rtc"
 
 [dependencies]
+shared = { version = "0.2.1", path = "../rtc-shared", package = "rtc-shared", default-features = false, features = [] }
+
 url = "2.5.0"
 rand = "0.8.5"
-thiserror = "1.0.57"
-substring = "1.4.5"
 
 [dev-dependencies]
 criterion = "0.5.1"

rtc-sdp/src/description/description_test.rs

@@ -1,7 +1,7 @@
 use super::common::*;
 use super::media::*;
 use super::session::*;
-use crate::error::{Error, Result};
+use shared::error::{Error, Result};
 
 use std::io::Cursor;
 use url::Url;

rtc-sdp/src/description/session.rs

@@ -4,9 +4,9 @@ use std::time::{Duration, SystemTime, UNIX_EPOCH};
 use std::{fmt, io};
 use url::Url;
 
-use crate::error::{Error, Result};
 use crate::lexer::*;
 use crate::util::*;
+use shared::error::{Error, Result};
 
 use super::common::*;
 use super::media::*;

rtc-sdp/src/extmap/mod.rs

@@ -2,8 +2,8 @@
 mod extmap_test;
 
 use super::direction::*;
-use super::error::{Error, Result};
 use crate::description::common::*;
+use shared::error::{Error, Result};
 
 use std::fmt;
 use std::io;

rtc-sdp/src/lexer/mod.rs

@@ -1,5 +1,5 @@
 use super::description::session::SessionDescription;
-use super::error::{Error, Result};
+use shared::error::{Error, Result};
 
 use std::io;
 use std::io::SeekFrom;

rtc-sdp/src/lib.rs

@@ -6,8 +6,6 @@ pub mod direction;
 pub mod extmap;
 pub mod util;
 
-mod error;
 pub(crate) mod lexer;
 
 pub use description::{media::MediaDescription, session::SessionDescription};
-pub use error::Error;

rtc-sdp/src/util/mod.rs

@@ -1,7 +1,7 @@
 #[cfg(test)]
 mod util_test;
 
-use super::error::{Error, Result};
+use shared::error::{Error, Result};
 
 use std::collections::HashMap;
 use std::fmt;

rtc-shared/Cargo.toml

@@ -17,6 +17,7 @@ replay = []
 
 [dependencies]
 thiserror = "1.0.58"
+substring = "1.4.5"
 bytes = "1.5.0"
 aes-gcm = { version = "0.10.3", features = ["std"] }
 url = "2.5.0"

rtc-shared/src/error.rs

@@ -6,6 +6,7 @@ use std::net::SocketAddr;
 use std::num::ParseIntError;
 use std::string::FromUtf8Error;
 use std::time::SystemTimeError;
+use substring::Substring;
 use thiserror::Error;
 
 pub type Result<T> = std::result::Result<T, Error>;
@@ -1455,6 +1456,26 @@ pub enum Error {
     #[error("not long enough to be a RTP Packet")]
     ErrRTPTooShort,
 
+    //SDP
+    #[error("codec not found")]
+    CodecNotFound,
+    #[error("missing whitespace")]
+    MissingWhitespace,
+    #[error("missing colon")]
+    MissingColon,
+    #[error("payload type not found")]
+    PayloadTypeNotFound,
+    #[error("SdpInvalidSyntax: {0}")]
+    SdpInvalidSyntax(String),
+    #[error("SdpInvalidValue: {0}")]
+    SdpInvalidValue(String),
+    #[error("sdp: empty time_descriptions")]
+    SdpEmptyTimeDescription,
+    #[error("parse extmap: {0}")]
+    ParseExtMap(String),
+    #[error("{} --> {} <-- {}", .s.substring(0,*.p), .s.substring(*.p, *.p+1), .s.substring(*.p+1, .s.len()))]
+    SyntaxError { s: String, p: usize },
+
     //Third Party Error
     #[error("{0}")]
     Sec1(#[source] sec1::Error),