[이지민] - 민겸 수, 이모티콘 할인 행사 #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bngsh
approved these changes
Feb 25, 2024
| println(minResult) | ||
| } | ||
|
|
||
| private fun changeToDecimal(first: Int, last: Int, mgValue: String, maxResult: StringBuilder) { |
There was a problem hiding this comment.
최대랑 최소랑 겹치는 부분을 따로 함수로 빼서 깔끔하네요!!
Comment on lines
+13
to
+14
| getCombination(0, emoticons.size, mutableListOf<Int>()) | ||
| makeDiscountPrices(emoticons) |
There was a problem hiding this comment.
함수를 역할별로 나눠서 필요한 값들을 다 구하고 마지막에 답을 갱신하는 흐름이 좋았워요
jhg3410
approved these changes
Feb 25, 2024
Comment on lines
+13
to
+14
| getCombination(0, emoticons.size, mutableListOf<Int>()) | ||
| makeDiscountPrices(emoticons) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 from issue #206 📌
📋문제 목록📋