[장희직] - 민겸 수, 이모티콘 할인 행사 #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bngsh
approved these changes
Feb 25, 2024
| } | ||
| } | ||
|
|
||
| private fun String.getMaxDecimal(): String { |
Comment on lines
+27
to
+29
| discounts.add(discountRate) | ||
| findDiscounts(discounts = discounts, counts = counts) | ||
| discounts.removeLast() |
There was a problem hiding this comment.
이렇게 해주면 매번 배열을 새로 만들지 않아도 되는군요!
jeeminimini
approved these changes
Feb 25, 2024
| } | ||
| } | ||
|
|
||
| private fun String.getMaxDecimal(): String { |
|
|
||
| private fun findDiscounts(discounts: MutableList<Int>, counts: Int) { | ||
| if (discounts.size == counts) { | ||
| getResult(discounts).run { |
There was a problem hiding this comment.
여기서 결과를 계산해서 discounts를 복사할 필요가 없었군요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 from issue #206 📌
📋문제 목록📋
📍추가로 해결한 문제📍