increment version number in VHS on deletion

wellcomecollection · Sep 13, 2024 · 2d64bba · 2d64bba
1 parent 3efb871
commit 2d64bba
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/..._deletion_checker/src/main/scala/weco/pipeline/calm_deletion_checker/DeletionMarker.scala b/..._deletion_checker/src/main/scala/weco/pipeline/calm_deletion_checker/DeletionMarker.scala
@@ -22,7 +22,7 @@ class DeletionMarker(sourceTable: String)(implicit client: DynamoDbClient)
             .when(attributeExists("id"))
             .update(
               "id" === record.id,
-              set("isDeleted", true)
+              set("isDeleted", true) and add("version", 1),
             )
         )
         .map(_.toPayload)

diff --git a/...etion_checker/src/test/scala/weco/pipeline/calm_deletion_checker/DeletionMarkerTest.scala b/...etion_checker/src/test/scala/weco/pipeline/calm_deletion_checker/DeletionMarkerTest.scala
@@ -31,7 +31,10 @@ class DeletionMarkerTest
         val targetRecord = rows.head.toPayload
         val result = deletionMarker(targetRecord)
 
-        result.success.value shouldBe targetRecord.copy(isDeleted = true)
+        result.success.value shouldBe targetRecord.copy(
+            isDeleted = true,
+            version = targetRecord.version + 1
+        )
         getRecordFromTable(
           targetRecord.id,
           targetRecord.version,
@@ -48,7 +51,10 @@ class DeletionMarkerTest
         val targetRecord = rows.head.toPayload
         val result = deletionMarker(targetRecord)
 
-        result.success.value shouldBe targetRecord.copy(isDeleted = true)
+        result.success.value shouldBe targetRecord.copy(
+          isDeleted = true,
+          version = targetRecord.version + 1
+        )
         getRecordFromTable(
           targetRecord.id,
           targetRecord.version,
@@ -65,7 +71,10 @@ class DeletionMarkerTest
         val targetRecord = records.head.toPayload
         val result = deletionMarker(targetRecord)
 
-        result.success.value shouldBe targetRecord.copy(isDeleted = true)
+        result.success.value shouldBe targetRecord.copy(
+          isDeleted = true,
+          version = targetRecord.version + 1
+        )
         getRecordFromTable(
           targetRecord.id,
           targetRecord.version,