Use correct topic env var name in relation embedder #2808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-butcher
changed the title
paul-butcher
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
For wellcomecollection/platform#5870
Use the correct env var name for topic arn in the relation embedder, there is a mismatch causing the lambda to fail.
output_topic_arnis preferred to avoid confusion withtopic_arnswhich is used to subscribe input topics.How to test
How can we measure success?
The relation embedder lambda can process events.
Have we considered potential risks?
The 2024-11-18 pipeline is not the production pipeline yet, so a failure should not impact end users.