Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better retries #39

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Better retries #39

wants to merge 30 commits into from

Conversation

paul-butcher
Copy link
Contributor

What does this change?

This improves the handling of larger shoots by

  1. Being better at understanding what has already been transferred
  2. Only transferring sub shoots that are not already in born-digital-accessions.

How to test

To see how point 1, above, behaves:

  1. Set SOURCE_PROFILE and TARGET_PROFILE accordingly
  2. Populate a file shoots/accept-tab with shoot numbers.
  3. make the two incomplete transfer lists
  • make shoots/accept-tab.transfer_status.touchable
  • make shoots/accept-tab.transfer_status.needs_transfer

You should see only what you expect. You can fiddle with accept-tab.transfer_status to give the impression that some files (most pertinently parts of larger shoots, which were not properly dealt with before) have not been ingested (if they actually have been, they will appear in *.touchable), and you can include shoots that you know have not been transferred in the accept-tab list (they will appear in *.needs_transfer).

Point 2 has been fully exercised by the recent complete transfer.

How can we measure success?

The next time we transfer a batch of shoots, some of them will still fail.

In the case of the larger, broken-up shoots, we reingested some of the subshoots multiple times, even though they were successful. Next time, we will only successfully ingest them all once.

Have we considered potential risks?

This is a mitigation for some problems I encountered during the recent ingest.

@paul-butcher paul-butcher requested a review from a team as a code owner November 20, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant