Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(feed): load CSS in subfolder setups #467

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Conversation

welpo
Copy link
Owner

@welpo welpo commented Jan 18, 2025

Summary

Fixes CSS loading in subfolder installations by deriving the base path from the feed URL instead of relying on xml:base. Uses same logic as sitemap styling.

Related issue

N/A

Screenshots

Before:

before, no styling

After:

after, css is loaded

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have updated config.toml in tabi-start
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@welpo welpo added the bug Something isn't working label Jan 18, 2025
Copy link

netlify bot commented Jan 18, 2025

Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit 1fc2423
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/678ba9f7fd2d430008fe4a59
😎 Deploy Preview https://deploy-preview-467--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@welpo welpo merged commit c3b048d into main Jan 18, 2025
7 checks passed
@welpo welpo deleted the fix/feed-css-base-path branch January 18, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant