Add the --current-size and --exit-zero to optionally show current docker image size and avoid stop the CI even if exceed max_size and max-layers #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Dec 26, 2024
luzfcb
force-pushed
the
master
branch
2 times, most recently
from
3e8f93c to
b76c142
Compare
luzfcb
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #319 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 3 +1
Lines 33 58 +25
Branches 1 5 +4
=========================================
+ Hits 33 58 +25 ☔ View full report in Codecov by Sentry. |
and allow execute it as module via python -m docker_image_size_limit
|
@sobolevn done. Docker is failing because it tries to install version 2.1.0, however it has not been released yet. |
sobolevn
reviewed
Dec 27, 2024
| your-image-name:label size is 414.4 MiB | ||
| your-image-name:label exceeds 300MiB limit by 114.4 MiB | ||
|
|
||
| $ disl your-image-name:label 300MiB --max-layers=5 --current-size |
There was a problem hiding this comment.
I would say that the first example is redundant
| @@ -2,18 +2,33 @@ | |||
|
|
|||
| # Default values: | |||
| : "${INPUT_MAX_LAYERS:=-1}" | |||
| : "${INPUT_SHOW_CURRENT_SIZE:=false}" | |||
There was a problem hiding this comment.
This needs two steps to be properly initialized: see https://github.com/wemake-services/wemake-python-styleguide/blob/fa815ebfb3fd1457712812597de4c1320f83e1b9/scripts/entrypoint.sh#L3-L16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--current-sizeto display the current size of the docker image. Maybe partially fix Running without a size parameter should only display current size #224--exit-zeroto Exit with 0 even if docker image size/layers exceedmax_sizeandmax-layers__main__.pyentrypoint to be able execute via module, that itpython -m docker_image_size_limitfilesargument instead offileargument in thecodecovgithub action since it deprecate thefileargument in favor offiles2.1.0It Maybe introduce a breaking change since the
_check_imagefunction now return 3 values instead of 2