BREAKING: TYPO3 v12 support (#44)

* Migrated all fixtures to PHP.
* Removed version specific adjustments.

.gitattributes

@@ -1,4 +1,5 @@
 Tests export-ignore
+Patches export-ignore
 .gitlab-ci.yml export-ignore
 shell.nix export-ignore
 

.github/workflows/ci.yaml

@@ -15,12 +15,9 @@ jobs:
  strategy:
  matrix:
  php-version:
- - 7.2
- - 7.3
- - 7.4
- - 8.0
  - 8.1
  - 8.2
+ - 8.3
  steps:
  - name: Checkout
  uses: actions/checkout@v3
@@ -43,7 +40,7 @@ jobs:
  - name: Install PHP
  uses: shivammathur/setup-php@v2
  with:
- php-version: "7.4"
+ php-version: "8.2"
  tools: composer:v2
 
  - name: Install xmllint
@@ -71,14 +68,14 @@ jobs:
  - name: Install PHP
  uses: shivammathur/setup-php@v2
  with:
- php-version: "8.1"
+ php-version: "8.2"
  tools: composer:v2
 
  - name: Install dependencies
  run: composer install --prefer-dist --no-progress --no-suggest
 
  - name: Coding Guideline
- run: ./vendor/bin/php-cs-fixer fix
+ run: ./vendor/bin/php-cs-fixer fix --dry-run --diff
 
  code-quality:
  runs-on: ubuntu-latest
@@ -87,20 +84,12 @@ jobs:
  strategy:
  matrix:
  include:
- - php-version: '7.2'
- typo3-version: '^10.4'
- - php-version: '7.3'
- typo3-version: '^10.4'
- - php-version: '7.4'
- typo3-version: '^10.4'
- - php-version: '7.4'
- typo3-version: '^11.5'
- - php-version: '8.0'
- typo3-version: '^11.5'
  - php-version: '8.1'
- typo3-version: '^11.5'
+ typo3-version: '^12.4'
  - php-version: '8.2'
- typo3-version: '^11.5'
+ typo3-version: '^12.4'
+ - php-version: '8.3'
+ typo3-version: '^12.4'
  steps:
  - uses: actions/checkout@v3
 
@@ -124,20 +113,12 @@ jobs:
  strategy:
  matrix:
  include:
- - php-version: '7.2'
- typo3-version: '^10.4'
- - php-version: '7.3'
- typo3-version: '^10.4'
- - php-version: '7.4'
- typo3-version: '^10.4'
- - php-version: '7.4'
- typo3-version: '^11.5'
- - php-version: '8.0'
- typo3-version: '^11.5'
  - php-version: '8.1'
- typo3-version: '^11.5'
+ typo3-version: '^12.4'
  - php-version: '8.2'
- typo3-version: '^11.5'
+ typo3-version: '^12.4'
+ - php-version: '8.3'
+ typo3-version: '^12.4'
  steps:
  - uses: actions/checkout@v3
 
@@ -151,4 +132,4 @@ jobs:
  run: composer require --no-interaction --prefer-dist --no-progress "typo3/cms-core:${{ matrix.typo3-version }}" "typo3/cms-extbase:${{ matrix.typo3-version }}" "typo3/cms-frontend:${{ matrix.typo3-version }}" "typo3/cms-fluid:${{ matrix.typo3-version }}" "typo3/cms-filelist:${{ matrix.typo3-version }}" "typo3/cms-backend:${{ matrix.typo3-version }}" "typo3/cms-fluid-styled-content:${{ matrix.typo3-version }}"
 
  - name: PHPUnit Tests
- run: ./vendor/bin/phpunit --testdox
+ run: ./vendor/bin/phpunit --display-incomplete --display-skipped --display-deprecations --display-errors --display-notices --display-warnings

.php-cs-fixer.dist.php

@@ -9,20 +9,26 @@
  ->setRules([
  '@DoctrineAnnotation' => true,
  '@PSR2' => true,
+ 'array_indentation' => true,
  'array_syntax' => ['syntax' => 'short'],
+ 'attribute_empty_parentheses' => true,
  'blank_line_after_opening_tag' => true,
  'braces' => ['allow_single_line_closure' => true],
  'cast_spaces' => ['space' => 'none'],
  'compact_nullable_typehint' => true,
  'concat_space' => ['spacing' => 'one'],
  'declare_equal_normalize' => ['space' => 'none'],
+ 'declare_strict_types' => true,
  'dir_constant' => true,
+ 'fully_qualified_strict_types' => false,
  'function_to_constant' => ['functions' => ['get_called_class', 'get_class', 'get_class_this', 'php_sapi_name', 'phpversion', 'pi']],
  'function_typehint_space' => true,
+ 'global_namespace_import' => ['import_classes' => true, 'import_constants' => true, 'import_functions' => true],
  'lowercase_cast' => true,
  'method_argument_space' => ['on_multiline' => 'ensure_fully_multiline'],
  'modernize_strpos' => true,
  'modernize_types_casting' => true,
+ 'multiline_whitespace_before_semicolons' => ['strategy' => 'new_line_for_chained_calls'],
  'native_function_casing' => true,
  'new_with_braces' => true,
  'no_alias_functions' => true,
@@ -32,12 +38,14 @@
  'no_extra_blank_lines' => true,
  'no_leading_import_slash' => true,
  'no_leading_namespace_whitespace' => true,
+ 'no_multiline_whitespace_around_double_arrow' => true,
  'no_null_property_initialization' => true,
  'no_short_bool_cast' => true,
  'no_singleline_whitespace_before_semicolons' => true,
  'no_superfluous_elseif' => true,
  'no_trailing_comma_in_singleline_array' => true,
  'no_unneeded_control_parentheses' => true,
+ 'no_unneeded_import_alias' => true,
  'no_unused_imports' => true,
  'no_useless_else' => true,
  'no_whitespace_in_blank_line' => true,
@@ -54,8 +62,8 @@
  'phpdoc_types' => true,
  'phpdoc_types_order' => ['null_adjustment' => 'always_last', 'sort_algorithm' => 'none'],
  'return_type_declaration' => ['space_before' => 'none'],
- 'single_quote' => true,
  'single_line_comment_style' => ['comment_types' => ['hash']],
+ 'single_quote' => true,
  'single_trait_insert_per_statement' => true,
  'trailing_comma_in_multiline' => ['elements' => ['arrays']],
  'whitespace_after_comma_in_array' => true,

Classes/Caching/CacheManager.php

@@ -28,15 +28,7 @@
 
 class CacheManager
 {
- /**
- * @var Typo3CacheManager
- */
- private $cacheManager;
-
- /**
- * @var array
- */
- private $tags = [
+ private array $tags = [
  'tx_events_domain_model_date',
  'tx_events_domain_model_event',
  'tx_events_domain_model_organizer',
@@ -45,9 +37,8 @@ class CacheManager
  ];
 
  public function __construct(
- Typo3CacheManager $cacheManager
+ private readonly Typo3CacheManager $cacheManager
  ) {
- $this->cacheManager = $cacheManager;
  }
 
  public function addAllCacheTagsToPage(ContentObjectRenderer $cObject): void