Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta tags #49

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Add meta tags #49

merged 1 commit into from
Nov 29, 2023

Conversation

DanielSiepmann
Copy link
Contributor

A new class is added which will add meta tags for dates and events. The class has an interface which allows it to be replaced via DI to alter behaviour.

Refactor import regarding data handler. We now also need to add a new column "keywords". We use the new DataHandler approach. But that approach only covered relations so far. We therefore refactor that area to be more generic and use that one for new keywords column.

Relates: #10642

@DanielSiepmann DanielSiepmann self-assigned this Nov 29, 2023
@DanielSiepmann DanielSiepmann force-pushed the 10642-add-meta-tags branch 2 times, most recently from 166388b to f94cfbf Compare November 29, 2023 08:16
@DanielSiepmann DanielSiepmann marked this pull request as ready for review November 29, 2023 09:00
A new class is added which will add meta tags for dates and events.
The class has an interface which allows it to be replaced via DI to
alter behaviour.

Refactor import regarding data handler. We now also need to add a new
column "keywords". We use the new DataHandler approach.
But that approach only covered relations so far. We therefore refactor
that area to be more generic and use that one for new keywords column.

Relates: #10642
@DanielSiepmann DanielSiepmann merged commit 713bc4b into main Nov 29, 2023
12 checks passed
@DanielSiepmann DanielSiepmann deleted the 10642-add-meta-tags branch November 29, 2023 09:37
DanielSiepmann added a commit that referenced this pull request Jul 23, 2024
A new class is added which will add meta tags for dates and events.
The class has an interface which allows it to be replaced via DI to
alter behaviour.

Refactor import regarding data handler. We now also need to add a new
column "keywords". We use the new DataHandler approach.
But that approach only covered relations so far. We therefore refactor
that area to be more generic and use that one for new keywords column.

Relates: #10642
DanielSiepmann added a commit that referenced this pull request Jul 23, 2024
A new class is added which will add meta tags for dates and events.
The class has an interface which allows it to be replaced via DI to
alter behaviour.

Refactor import regarding data handler. We now also need to add a new
column "keywords". We use the new DataHandler approach.
But that approach only covered relations so far. We therefore refactor
that area to be more generic and use that one for new keywords column.

Relates: #10642
DanielSiepmann added a commit that referenced this pull request Jul 23, 2024
A new class is added which will add meta tags for dates and events.
The class has an interface which allows it to be replaced via DI to
alter behaviour.

Refactor import regarding data handler. We now also need to add a new
column "keywords". We use the new DataHandler approach.
But that approach only covered relations so far. We therefore refactor
that area to be more generic and use that one for new keywords column.

Relates: #10642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants