Generics and TypeScript limited to 4.6.*

[cmidgley]

This pull addresses two things:

1. Support for generics, as per Impossible to add in provider interfaces with generics.  #11.
2. Limits TypeScript in package.json to ~4.6.4, as recently released 4.7 does not currently work. Obviously back out this change when 4.7 is supported.

Passes all tests, and change #1 has been in my rig for a couple months now.

I did bump the version number and add a change log. Sorry if this was inappropriate - some smaller projects like it when I assist with the details, others find it a major faux pas! In the change log I refer to the labeled version, which of course does not exist yet. Glad to fix the repo to remove that if you prefer.

[wessberg]

Thanks for your PR! I've looked through it and added a few comments :)

[wessberg]

Note that this is just the development dependency of TypeScript, and won't restrict library consumers from installing and using TypeScript 4.7. If your intention is to restrict the consumer facing version of TypeScript, it will need to be addressed below it in the package.json file under peer dependencies. However, I would prefer not to do that, and instead look into what the root cause of this apparent regression may be.

[cmidgley]

I agree - my intent wasn't to fix the TS 4.7 issue, but to enable the tests to pass (and bring your attention to the 4.7 issue).
Glad to back this out - is that what you would prefer?

[wessberg]

Yes, I would prefer that we look into this TS 4.7 issue you mention here, maybe in a separate issue ☺️ I'm definitely going to be needing v4.7 support myself soon anyway, so we might as well leave it in.

[wessberg]

That NonNullAssertion there feels a bit unsafe. I would prefer that we handle it a bit more gracefully, ideally by taking the full text of the first token if it present, and falling back to taking the full text of the first type argument otherwise.
Something like:

// Move it up in a constant
const [firstTypeArgument] = node.typeArguments;

return factory.updateCallExpression(
          node,
          node.expression,
          node.typeArguments,
          [
            factory.createObjectLiteralExpression([
              factory.createPropertyAssignment(
                "identifier",
                factory.createStringLiteral(
                  (firstTypeArgument.getFirstToken()?.getFullText() ?? firstTypeArgument.getFullText()).trim()
                )
              ),
            ]),
          ]
        );

[wessberg]

The changelog is actually auto-generated based on the commit log whenever a new version is released. So, unfortunately these two lines would actually be lost. To achieve the same result, you can write commit messages along these lines :)

[cmidgley]

Sweet. I'll back this out.

[wessberg]

Awesome!

[cmidgley]

Sorry about the closures ... turns out git was very unhappy with my branch name (origin, stupid choice ... had to do with wanting to keep all my prior work and create a fresh branch origin to your code so I could create a clean pull for you). Renaming the branch caused github to close both PR's. New PR's coming...