debug: temporarily allow stack traces in production

wessberg · May 20, 2021 · c54008b · c54008b
1 parent 00fbb15
commit c54008b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 9 deletions.
diff --git a/src/api/middleware/error-middleware.ts b/src/api/middleware/error-middleware.ts
@@ -3,17 +3,12 @@ import {ApiError} from "../lib/api-error";
 import {generateErrorHtml} from "../../util/html/generate-html";
 import {pickAccept} from "../util/util";
 
-interface ErrorMiddlewareOptions {
-	removeStackTrace: boolean;
-}
+interface ErrorMiddlewareOptions {}
 
 export const errorMiddleware =
-	(options: Partial<ErrorMiddlewareOptions> = {}) =>
+	(_options: Partial<ErrorMiddlewareOptions> = {}) =>
 	async (ex: Error | ApiError, req: Request, res: Response, _: NextFunction): Promise<void> => {
 		const apiError = ApiError.ensureApiError(ex);
-		if (options.removeStackTrace) {
-			apiError.stack = undefined;
-		}
 
 		const contentType = pickAccept(req.header("accept"));
 

diff --git a/src/api/server/server.ts b/src/api/server/server.ts
@@ -45,7 +45,7 @@ export class Server implements IServer {
 		await this.metricsService.configureErrorHandlers(app);
 
 		// Apply fall-through error middleware
-		app.use(errorMiddleware({removeStackTrace: this.config.production}));
+		app.use(errorMiddleware());
 		this.app = app;
 	}
 

diff --git a/test/api/api.test.ts b/test/api/api.test.ts
@@ -59,7 +59,7 @@ test(`Generates an JSON-formatted welcome payload when a request is sent to '${c
 	}
 });
 
-test.only(`Sends metrics data when an unsupported User-Agent header is discovered, but still responds with OK`, async t => {
+test(`Sends metrics data when an unsupported User-Agent header is discovered, but still responds with OK`, async t => {
 	const metricsService = container.get<IMetricsService>();
 	const result = await sendRequest({
 		path: `${constant.endpoint.polyfill}?features=intersection-observer`,