refactor: remove incompatible edge packages #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tmm
commented
Mar 9, 2024
Comment on lines
-38
to
-40
| exclude: [ | ||
| /.+\.(gif|jpe?g|tiff?|png|webp|bmp|woff|eot|woff2|ttf|otf|ico|txt)$/, | ||
| ], |
There was a problem hiding this comment.
Was blocking devtools script from loading
There was a problem hiding this comment.
Hmm, this will break serving assets that coexist on the same level as hono routes.
tmm
commented
Mar 9, 2024
| @@ -245,7 +245,7 @@ export function Tabs() { | |||
| <div | |||
| class={rowClass} | |||
| x-cloak | |||
| x-show="data.context.verified !== undefined" | |||
| x-show="body && data.context.verified !== undefined" | |||
There was a problem hiding this comment.
unrelated tweak: only show verified when there's a frame packet (e.g. request body)
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/frog@0.4.8, npm/happy-dom@13.3.8 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed
@farcaster/coreandhappy-dom