-
-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macos: floating window support #4567
Conversation
Signed-off-by: rawnly <rawnly@users.noreply.github.com>
Signed-off-by: rawnly <rawnly@users.noreply.github.com>
removed wrong values and implemented `From<T>` trait Signed-off-by: rawnly <rawnly@users.noreply.github.com>
Signed-off-by: rawnly <rawnly@users.noreply.github.com>
any feedback on this? @wez |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for diving in!
I think this PR needs to consider all platforms; both X11 and Windows have an AlwaysOnTop concept, so the configuration and actions need to expand and be ready for that, even if you're not in a position to implement and test for those platforms yourself.
I've made some suggestions with that in mind for your macOS implementation.
I think you could probably get close to making this work on windows and perhaps also X11 if you took a peek at the equivalent functionality in the winit
crate. I'm not going to require that you do both of these in this PR, but it would be very helpful if you could take a crack at making it compile there via the CI as a kind of first-pass at that.
Thanks for the review I'll have a look at it asap! |
"The only place where the behavior should vary by os is inside the window crate"
Thanks for the feedback, I applied the changes as you suggested, now there are 3 ways to set levels, via I moved the |
i left docs for the so i don't have to write them again every time 😅 |
Co-authored-by: Wez Furlong <wez@wezfurlong.org>
Co-authored-by: Wez Furlong <wez@wezfurlong.org>
Co-authored-by: Wez Furlong <wez@wezfurlong.org>
Co-authored-by: Wez Furlong <wez@wezfurlong.org>
Co-authored-by: Wez Furlong <wez@wezfurlong.org>
Co-authored-by: Wez Furlong <wez@wezfurlong.org>
Co-authored-by: Wez Furlong <wez@wezfurlong.org>
it should be everything fine for the CI :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks; just a couple of minor things remain here for macOS!
Co-authored-by: Wez Furlong <wez@wezfurlong.org>
Co-authored-by: Mike Duminy <4092035+mikeduminy@users.noreply.github.com>
Co-authored-by: Wez Furlong <wez@wezfurlong.org>
any feedback so far? |
@wez ? |
Thanks! |
Added
ToggleFloatingWindow
on macos.Tested on macOS Sonoma (14.0)
Demo
CleanShot.2023-11-12.at.16.14.33.mp4
fixes #4566