Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to more recent Rust #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

wycats
Copy link

@wycats wycats commented Sep 27, 2021

replace proc_macro_hack with proc_macro

This allows nested macro executions (and therefore allows macros in other crates to abstract the gen macros).

add rust-toolchain with nightly toolchain

Otherwise, cargo check --all-features fails, because it attempts to enable the nightly feature and fails on stable.

fix a few lints

Similarly, cargo check --all-features enables feature = "strict", which turns the warnings into hard errors. I'm not sure if they were present a year ago (and ignored), but they fail the build today with --all-features.

## replace proc_macro_hack with proc_macro

This allows nested macro executions (and therefore allows macros in other
crates to abstract the gen macros).

## add rust-toolchain with nightly toolchain

Otherwise, `cargo check --all-features` fails, because it attempts to
enable the nightly feature and fails on stable.

## fix a few lints

Similarly, `cargo check --all-features` enables `feature = "strict"`,
which turns the warnings into hard errors. I'm not sure if they were
present a year ago (and ignored), but they fail the build today with
`--all-features`.
@DevinR528
Copy link
Collaborator

I can run the CI and aprove a PR but I don't feel comfortable merging and @whatisaphone has been busy with other things so it might be a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants