Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset declarative to false when calling attachShadow #1245

Merged
merged 2 commits into from
Jan 14, 2024

Conversation

mfreed7
Copy link
Contributor

@mfreed7 mfreed7 commented Jan 9, 2024

This was an oversight in the spec, and this matches browser behavior. This makes a second call to attachShadow() throw.

This test already tests this condition: shadow-dom/declarative/declarative-shadow-dom-attachment.html

Closes #1234

@emilio


💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Jan 12, 2024, 7:32 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 CSS Spec Preprocessor - CSS Spec Preprocessor is the web service used to build Bikeshed specs.

🔗 Related URL

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>500 Internal Server Error</title>
</head><body>
<h1>Internal Server Error</h1>
<p>The server encountered an internal error or
misconfiguration and was unable to complete
your request.</p>
<p>Please contact the server administrator at 
 [no address given] to inform them of the time this error occurred,
 and the actions you performed just before this error.</p>
<p>More information about this error may be available
in the server error log.</p>
<hr>
<address>Apache/2.4.10 (Debian) Server at api.csswg.org Port 443</address>
</body></html>

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

This was an oversight in the spec, and this matches browser
behavior. This makes a second call to `attachShadow()` throw.

Closes whatwg#1234
Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

dom.bs Outdated Show resolved Hide resolved
dom.bs Outdated Show resolved Hide resolved
@annevk annevk merged commit d94ce87 into whatwg:main Jan 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Element.attachShadow should set the declarative flag to false of an existing declarative shadow dom.
3 participants