Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce same parameters for attachShadow on declarative shadow root #1246

Merged
merged 8 commits into from
Feb 16, 2024
Merged

Enforce same parameters for attachShadow on declarative shadow root #1246

merged 8 commits into from
Feb 16, 2024

Commits on Jan 27, 2024

  1. Just assert that a cloned node is not a shadow host

    @mfreed7
    mfreed7 committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    cbad36e View commit details
    Browse the repository at this point in the history

  2. Enforce same parameters for attachShadow on declarative shadow root 

    Per the discussion at whatwg#1235, this PR changes the behavior when calling `attachShadow()` on a node with an existing declarative shadow root. Now, if the parameters do not match between the arguments to `attachShadow()` and the existing root, throw an exception. Prior behavior was to silently return the declarative root as-is, with mismatched parameters.
    @mfreed7
    mfreed7 committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    3b3e70a View commit details
    Browse the repository at this point in the history

  3. Address comments

    @mfreed7
    mfreed7 committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    13198db View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Address comments

    @mfreed7
    mfreed7 committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    1c63c4f View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Fix slotAssignment to be a string

    @mfreed7
    mfreed7 committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    149f31c View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2024

  1. Remove checks except for mode

    @mfreed7
    mfreed7 committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    1c0b37c View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Address comments

    @mfreed7
    mfreed7 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    16dcb39 View commit details
    Browse the repository at this point in the history

  2. nits

    @annevk
    annevk committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    30a0f3b View commit details
    Browse the repository at this point in the history