Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore missing word in attach a shadow root #1273

Conversation

dandclark
Copy link
Contributor

@dandclark dandclark commented Apr 3, 2024

Restore a term that was accidentally removed from step 2 of https://dom.spec.whatwg.org/#concept-attach-a-shadow-root in #892.


Preview | Diff

@dandclark dandclark requested review from annevk and mfreed7 April 3, 2024 18:38
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 3, 2024
In [1] I mistakenly changed the check for whether an element has a
valid shadow name to include the full qualified name rather than just
the local name. Using only the local name is correct per the intent
of the spec [2] (although the key word is missing from the spec due to
a bug; see [3]).

Fix this check (and the corresponding check for EditContext) to only
include the local name.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/4617146
[2] https://dom.spec.whatwg.org/#concept-attach-a-shadow-root
[3] whatwg/dom#1273

Bug: 331239166
Change-Id: Ic01b26ac592ce16c36017925db702f5b495b6165
Copy link
Contributor

@mfreed7 mfreed7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks for the fix!

@annevk
Copy link
Member

annevk commented Apr 4, 2024

Thanks Dan!

@annevk annevk merged commit b9700e0 into whatwg:main Apr 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants