Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstate the hierarchy restrictions #91

Closed
wants to merge 4 commits into from
Closed

Reinstate the hierarchy restrictions #91

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e643797
Reinstate the hierarchy restrictions
foolip May 22, 2017
44b0c10
Add back recursive ready check from https://github.com/whatwg/fullscr…
foolip May 23, 2017
81465e9
Make dialog.requestFullscreen() an error
foolip May 23, 2017
fb22071
In #top-layer-add, assert that the element isn't already present
foolip May 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions fullscreen.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,12 @@ if all of the following are true, and false otherwise:
<ul>
<li><p><var>element</var> is <a>connected</a>.

<li><p><var>element</var>'s <a>node document</a>'s <a>fullscreen element</a> is null, or is an
<a>inclusive ancestor</a> of <var>element</var>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to invoke this check recursively for its browsing context container if any.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right, the ready check used to be recursive but I removed that in #52.

<!-- If /element/ is the fullscreen element, nothing happens -->

<li><p><var>element</var> has no <a>ancestor</a> <{iframe}> <a>element</a>.

<li><p><var>element</var>'s <a>node document</a> is <a>allowed to use</a> the feature indicated by
attribute name <code>allowfullscreen</code>.
<!-- cross-process, recursive -->
Expand Down