Merge pull request #70 from whywaita/fix/format-slash

RepoURL return only one slash

pkg/datastore/interface.go

@@ -5,7 +5,8 @@ import (
 	"database/sql"
 	"errors"
 	"fmt"
-	"path"
+	"net/url"
+	"strings"
 	"time"
 
 	uuid "github.com/satori/go.uuid"
@@ -75,7 +76,14 @@ func (t *Target) RepoURL() string {
 		serverURL = t.GHEDomain.String
 	}
 
-	return path.Join(serverURL, t.Scope)
+	s := strings.Split(serverURL, "://")
+
+	var u url.URL
+	u.Scheme = s[0]
+	u.Host = s[1]
+	u.Path = t.Scope
+
+	return u.String()
 }
 
 // OwnerRepo return :owner and :repo

pkg/datastore/interface_test.go

@@ -0,0 +1,48 @@
+package datastore_test
+
+import (
+	"database/sql"
+	"strings"
+	"testing"
+
+	"github.com/whywaita/myshoes/pkg/datastore"
+)
+
+func TestTarget_RepoURL(t *testing.T) {
+	tests := []struct {
+		input datastore.Target
+		want  string
+		err   bool
+	}{
+		{
+			input: datastore.Target{
+				GHEDomain: sql.NullString{
+					Valid:  false,
+					String: "",
+				},
+				Scope: "example/octocat",
+			},
+			want: "https://github.com/example/octocat",
+			err:  false,
+		},
+		{
+			input: datastore.Target{
+				GHEDomain: sql.NullString{
+					Valid:  true,
+					String: "https://github-enterprise.example.com",
+				},
+				Scope: "example",
+			},
+			want: "https://github-enterprise.example.com/example",
+			err:  false,
+		},
+	}
+
+	for _, test := range tests {
+		got := test.input.RepoURL()
+
+		if !strings.EqualFold(got, test.want) {
+			t.Fatalf("want %s, but got %s", test.want, got)
+		}
+	}
+}