Use 0x API #2
Open
Use 0x API #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jainkunal
requested changes
Oct 25, 2023
src/wido-compound-sdk.ts
Outdated
| ? quoteResponse.toTokenAmount | ||
| : "0"; | ||
| const minToAmount = supported && quoteResponse.minToTokenAmount | ||
| ? quoteResponse.minToTokenAmount | ||
| const minToAmount = minToTokenAmount |
There was a problem hiding this comment.
Let's raise an error when the minToTokenAmount is not present instead of setting it to 0
| // invoke Wido contract | ||
| const tx = await widoCollateralSwapContract.functions.swapCollateral( | ||
| existingCollateral, | ||
| finalCollateral, | ||
| sigs, | ||
| widoSwap, | ||
| cometAddress | ||
| swapQuote.data |
There was a problem hiding this comment.
It seems like we are passing calldata for 0x when the contract expects it to be WidoRouter calldata. Wrap the 0x calldata in WidoRouter's executeOrder function.
| @@ -217,7 +213,7 @@ export class WidoCompoundSdk { | |||
|
|
|||
| // construct & return quote | |||
| return { | |||
| isSupported: supported, | |||
| isSupported: true, | |||
There was a problem hiding this comment.
Remove to and tokenManager fields since they are not used.
Removed the getBestProvider method and the LoanProviders class because both were unused
jainkunal
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.