Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Drawables: revenge of the lint #665

Merged
merged 5 commits into from
Dec 29, 2023
Merged

Conversation

rksh
Copy link
Contributor

@rksh rksh commented Dec 28, 2023

A bunch of little visual linting checks. Grouped together because none of these reall bear much review.

  • xhdpi drawable asset directory was missing a lot of versions
  • an old, low-res grayscale planet icon was doing mixed/triple duty at points in the UI
  • android 24-29 had a mismatched icon in notification bar
  • DP sizes in icons were inconsistent across DPI folders
  • removing a lint warning in our port of the map bubble UI (because we learned it from Google)
  • an errant dimens entry

Copy link
Member

@bobzilladev bobzilladev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i assume it looks good!

@rksh rksh merged commit c594131 into wiglenet:main Dec 29, 2023
1 check passed
@rksh rksh deleted the revenge_of_the_lint branch January 20, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants