[ENH] Upload complete broadcast #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 30, 2024 18:52
…ome code/re-using CERTTRANS, queing requests
…andle the transition more cleanly
bobzilladev
approved these changes
Feb 7, 2024
| getApplicationContext().unbindService(state.serviceConnection); | ||
| final Context c = getApplicationContext(); | ||
| if (null != c) { | ||
| getApplicationContext().unbindService(state.serviceConnection); |
There was a problem hiding this comment.
Missed changing to reference c
uhtu
approved these changes
Feb 14, 2024
| .map(UploadReseponse.UploadTransaction::getTransId) | ||
| .collect(Collectors.toList()); | ||
| if (transIds.size() > 0) { | ||
| intent.putExtra("transIds", transIds.toString()); |
There was a problem hiding this comment.
do we care about doing this toString() more than once?
i suppose these are not frequent.
There was a problem hiding this comment.
it's sillier than that- the client doesn't currently support multiple CSVs/archive upload - so transIds will always be a single-item list. Just doing this to correctly process the API response should we start supporting multi-archive. Cleaning up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing #683 - sending a broadcast intent on upload success or failure.
These are (respectively)
net.wigle.wigleandroid.UPLOAD_COMPLETEandnet.wigle.wigleandroid.UPLOAD_FAILED.As a part of this change, I've also moved the
OkFileUploadercore call contents to WiGLEApiManager, our API implementation class. This necessitated numerous changes and begged certain cleanups, including:Some of the changes here may benefit from further refactoring, but this change set is getting large, and further changes (e.g. combining our various progress interaction implementations) would increase risk.