Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Null check route list #697

Merged
merged 2 commits into from
Apr 2, 2024
Merged

[FIX] Null check route list #697

merged 2 commits into from
Apr 2, 2024

Conversation

rksh
Copy link
Contributor

@rksh rksh commented Apr 1, 2024

these are almost certainly race conditions/corner cases on shutdown, but might as well check.

@rksh rksh requested a review from bobzilladev April 1, 2024 17:23
bobzilladev
bobzilladev approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@bobzilladev bobzilladev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null checks are part of this balanced breakfast

@bobzilladev bobzilladev merged commit ac310fe into wiglenet:main Apr 2, 2024
1 check passed
@rksh rksh deleted the null_check_route_list branch April 2, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobzilladev bobzilladev bobzilladev approved these changes

Assignees

@bobzilladev bobzilladev

Labels
bug please review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rksh @bobzilladev