Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh translation update #710

Merged
merged 17 commits into from
Nov 7, 2024
Merged

zh translation update #710

merged 17 commits into from
Nov 7, 2024

Conversation

Artoria2e5
Copy link
Contributor

  • Manually reviewed all zh-rCN translations, which seems to be the only one with non-machine content
  • Automatically turned these to TW and HK with OpenCC. Too lazy to review those, but can't be worse than MT.
  • Fixed the most obvious breakages of zh description.

* Manually reviewed all zh-rCN translations, which seems to be the only one with non-machine content
* Automatically turned these to TW and HK with OpenCC. Too lazy to review those, but can't be worse than MT.
* Fixed the most obvious breakages of zh description.
Copy link
Contributor

@rksh rksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

username / password keys no longer in correct language in Traditional translations - please update!

<string name="data_activity_name">WiGLE WiFi - 資料庫</string>
<string name="dbresult_activity_name">WiGLE WiFi - 搜尋結果</string>
<string name="upload_button">上傳到WiGLE.net</string>
<string name="使用者名稱">WiGLE 使用者名稱</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid string key

<string name="dbresult_activity_name">WiGLE WiFi - 搜尋結果</string>
<string name="upload_button">上傳到WiGLE.net</string>
<string name="使用者名稱">WiGLE 使用者名稱</string>
<string name="密碼">WiGLE 密碼</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid string key

<string name="data_activity_name">WiGLE WiFi - 資料庫</string>
<string name="dbresult_activity_name">WiGLE WiFi - 搜尋結果</string>
<string name="upload_button">上傳到WiGLE.net</string>
<string name="使用者名稱">WiGLE 使用者名稱</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid string key

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be "username"

<string name="dbresult_activity_name">WiGLE WiFi - 搜尋結果</string>
<string name="upload_button">上傳到WiGLE.net</string>
<string name="使用者名稱">WiGLE 使用者名稱</string>
<string name="密碼">WiGLE 密碼</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalid string key

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be "password"

@rksh rksh merged commit 8e4364e into wiglenet:main Nov 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants