-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ELY-2828] Replace wildcard imports with specific imports inside X500PrincipalBuilderTest.java #2220
Conversation
…th2TokenSecurityRealmTest.java
@Samith10 Just a small comment, looks like your changes for ELY-2826 also ended up in this PR. |
1+ looks good |
…th2TokenSecurityRealmTest.java
…PrincipalBuilderTest.java
@Samith10 FYI you seem to have changes from a previous commit included in this PR as well, do you need some help removing that one? (If you look at the changes there are two files changed). |
You can use something like: $ git rebase -i HEAD~2 [Note corrected git command from 'git commit rebase' to 'git rebase'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Samith10 Thank you!
I have left a small comment that can help resolve the error you see in the CI
@@ -18,7 +18,7 @@ | |||
|
|||
package org.wildfly.security.x500; | |||
|
|||
import static org.junit.Assert.*; | |||
import static org.junit.Assert.assertEqua; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is supposed to be assertEquals
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sorry just making tiny changes to figure out merge issues
Hello @Samith10 |
https://issues.redhat.com/browse/ELY-2828