-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for settings.xml #3
base: master
Are you sure you want to change the base?
Conversation
I'm not sure these changes are appropriate given that they're related to Red Hat products. WildFly Swarm is not a product, only an upstream project. |
It should be implemented irrespective of community or enterprise, these were just examples. The same is done also for the WildFly STI. Otherwise builds just take too long on OpenShift. |
But you've added profiles for eap repositories, etc. What is the main reason for needing settings.xml? |
I can remove the enterprise repos. The benefits of being able to provide Maven settings are:
|
So you can disregard this pull request, I will send an enhanced version with the clean-up on the repos later. |
What is it about a settings.xml that improves the build time? |
Of course you need to override this "template" settings.xml with URLs pointing to your Maven repository (for example Nexus) that can act as a caching proxy as otherwise artifacts are always pulled from the internet when creating new apps. |
I just removed the enterprise repos ... |
Now in a source project a settings.xml can be provided in the configuration folder similar to JBoss EAP and JBoss Fuse xPaaS images.