crystal tool format with Crystal 1.15.0-dev
#289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI still fails with formatter issues. I presume that's because the nix flake uses an earlier Crystal version which does not yet accept the new formatter rules. |
|
Yeah I was just looking at that, it looks like the most current release on nixpkgs is still Crystal 1.11.2 :/ |
|
Updated my old 1.12 pr to be 1.14 NixOS/nixpkgs#303173. I tried this time posting on their forum to see if someone will review it this time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crystal nightly has a couple new formatter rules enabled: crystal-lang/crystal#14718
The changes are backwards-compatible, so Crystal 1.14.0 won't complain about the new format.