Extra warnings added and fixes to make them clear #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
william-dawson
force-pushed
the
more_pendantic
branch
from
e1d356b
to
e172f89
Compare
Credit to ChatGPT
Apparently the version of gfortran on github CI is so absurdly broken that it gives a warning about C++ style comments in a Fortran file...
william-dawson
force-pushed
the
more_pendantic
branch
from
4219ace
to
91200d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChatGPT recommended to me some extra flags to throw as debug options. Based on warnings from those flags, modifications were made. In addition, the cray compiler complained about a few intent parameters, which I fixed.
Importantly: mpi communicators are now passed around as intent(in) when possible, instead of trying to force inout. I thought inout was more intentional because while the handle isn't change, the internal state of a communicator is. But this leads to problems with gathering matrix values, etc.