Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(changelog): version v0.24.1 [citest skip] #294

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

richm
Copy link
Collaborator

@richm richm commented Jul 4, 2024

Update changelog and .README.html for version v0.24.1

Signed-off-by: Rich Megginson rmeggins@redhat.com

Update changelog and .README.html for version v0.24.1

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@mattwillsher
Copy link
Member

Please fix the tests before release.

@Jakuje
Copy link
Collaborator

Jakuje commented Jul 4, 2024

Please fix the tests before release.

There is a fix for the centos7 in roles-ansible/check-ansible-centos-centos7-action#2 waiting to get merged. We can use my fork for the time being, but the maintainer was usually responsive to PRs.

@mattwillsher
Copy link
Member

Either is fine - we should not merge with failed tests. If we use your branch @Jakuje, please raise an issue or PR to revert once upstream is fixed. Failed test for a CentOS version on a CentOS related release looks bad, particularly being so visible.
Being picky I'd say this is a feature release not a fix, but that's not a blocker.

Copy link
Collaborator

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI on CentOS 7 is fixed. The change to the action is merged so ack.

@mattwillsher mattwillsher merged commit 7c58804 into willshersystems:main Jul 23, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants