Bugfix for handling gcode state G38 #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a TCP connection it will block while establishing the connection and will not display the connection status or message until after it has done a TCP handshake. Make sure the status and message is dispatched before the connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UGS parser expects G38 to have an axis parameter. However, if the controller is in a G38 modal state and a gcode parser state command is issued these commands can't be applied to the gcode state:
With this fix, the internal parser will not make it mandatory to have an axis to a probe command, leaving the command validation to the controller.
Fix for #2386