Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some small designer fixes #2467

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Some small designer fixes #2467

merged 3 commits into from
Feb 16, 2024

Conversation

werckmeister
Copy link
Contributor

This pull request includes some minor adjustments aimed at making it easier and more natural to create and position objects in the designer.

  1. Now, when you create a basic shape like an ellipse, point, or rectangle, it will be automatically selected for you.
  2. A move action (and related events) will only occur if there is a noticeable change (delta > 0). This prevents accidental moves when clicking on certain controls.
  3. The bounds (size and position) will be updated immediately after a change but before any notifications are sent out. This ensures that event handlers receive the most up-to-date information and don't use outdated cached data.

Martijn Werkhoven and others added 3 commits February 16, 2024 19:12
- Only perform a move (and event cascade) for a delta > 0. I.e. avoid move on click.
- Invalidate bounds after a change but before notification. I.e. avoid event handlers to use stale cached information.
@breiler
Copy link
Collaborator

breiler commented Feb 16, 2024

Feels much nicer, thanks!

@breiler breiler merged commit eab6cbf into winder:master Feb 16, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants