feat: add multi-language support (Chinese, English and French) #6
Conversation
|
Amzing work! I had considered the feature of multi-language before, but I put it on hold due to time constraints and other reasons. Please give me some time to review your pr. 😀 |
|
How about using i18n libraries like WPFLocalizeExtension? Would it be more flexible and convenient? |
There was a problem hiding this comment.
ci build fail:
CSC : error CS2001: Source file 'D:\a\elaphureLink\elaphureLink\elaphureLink.Wpf\Properties\Resources.Designer.cs' could not be found. Should we delete this?
There was a problem hiding this comment.
Well, it looks like these are modifications to the source files. Do you need to submit the changes to csproj along with them?
There was a problem hiding this comment.
These files were empty(Resources.resx/Resources.resx.cs), I might delete them.
There was a problem hiding this comment.
Well, it looks like these are modifications to the source files. Do you need to submit the changes to csproj along with them?
Oups, I didn't submit changes to .csproj, I'm beginner to C# and WPF, should I submit the .csproj file along with the commit ?
There was a problem hiding this comment.
Well, it looks like these are modifications to the source files. Do you need to submit the changes to csproj along with them?
Oups, I didn't submit changes to .csproj, I'm beginner to C# and WPF, should I submit the .csproj file along with the commit ?
Yes. You can submit the changes to related files such as .csproj on the basis of this patch.
😒I'm not expert in C#/WPF, I just used the first solution comes to me. |
The core ideas of the two method are consistent. Maybe we can migrate to an i18n library. Now let's solve the compile issue first. 😉 |
|
I
I will create a new PR tomorrow by cleaning all non-staged changes on my local repo. I close this PR for the moment. |
Thank you for your commit! |
Used .resx resource file to achieve the localization function.
The default language is english, and auto-selected based on the system language (WPF built-in behavior).