Fix pixman's pkgconfig file #1001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaysonsantos Thanks so much for your first contribution! One thing I'm concerned with is that we are pulling in the pixman-1.pc.in file as a patch unchanged, which isn't probably a huge deal, but it would be better if we were just using the upstreamed file if it is possible. I noticed that Pixman added a Meson build backend which would probably take care of installing all the right files for us automatically, maybe we should update to it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix an issue when building cairo, as it won't find pixman-1 on pkgconfig, it will try to download from git which normally works unless you have git in a different path like installed by scoop.