Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x264: Generate and install pdb files in debug-optimized configuration #1040

Merged
merged 2 commits into from
Aug 29, 2023
Merged

x264: Generate and install pdb files in debug-optimized configuration #1040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
932b0d7
x264: Install pdb files in debug configuration
AlessandroBono Aug 28, 2023
2e59c11
x264: Generate and install pdb files in debug-optimized configuration
AlessandroBono Aug 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions gvsbuild/patches/x264/build/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ if [ "$build_type" = "debug" ]; then
configure_cmd[idx++]="--extra-cflags=-MDd -Od -Zi"
fi

if [ "$build_type" = "debug-optimized" ]; then
configure_cmd[idx++]="--extra-ldflags=-DEBUG:FULL"
fi

CC=cl "${configure_cmd[@]}"

make
Expand Down
11 changes: 10 additions & 1 deletion gvsbuild/projects/x264.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,18 @@ def __init__(self):
)

def build(self):
configuration = (
"debug-optimized"
if self.opts.release_configuration_is_actually_debug_optimized
else self.opts.configuration
)
msys_path = Project.get_tool_path("msys2")
self.exec_vs(
r"%s\bash build\build.sh %s %s"
% (
msys_path,
convert_to_msys(self.builder.gtk_dir),
self.builder.opts.configuration,
configuration,
),
add_path=msys_path,
)
Expand All @@ -52,4 +57,8 @@ def build(self):
working_dir=os.path.join(self.builder.gtk_dir, "lib"),
)

if configuration in ["debug-optimized", "debug"]:
self.install(r".\libx264-164.pdb bin")
self.install(r".\x264.pdb bin")

self.install(r".\COPYING share\doc\x264")