Fix Visual Studio version search #1366
Conversation
|
Hi @KyleSiefring, thanks for the contribution. Could you please explain more about the issue? What is your setup and what does this fix? |
|
I have both the Visual Studio 2017 (version number 15.x) build tools installed and Visual Studio 2022 (version number 17.x) installed. The problem is that 2017 shows up in the list passed to this function before 2022. In that case, if we search for version 17 (again 2022), we end up selecting the 2017 edition based on the path to the tools. Here are the current editions (year) and version number pairs to make what I'm saying a little clearer. gvsbuild/gvsbuild/utils/builder.py Line 98 in 240dc5b |
|
Thanks! Can you please run |
Fix how the version of visual studio is selected. Visual Studio is selected by checking the path for the presence of either the year or the version number. Unfortunately, some version number are present in different editions. This can lead to the wrong installed version being selected. For example, Visual Studio 2022 has a version of 17, so specifying the use of version 17 can result in 2017 being selected instead.
KyleSiefring
force-pushed
the
fix_vs_version_check
branch
from
34aea98
to
ea3e83a
Compare
Prevents vs2017 from being used when version 17 (2022) is specified.