Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update librsvg to version 2.59.1 #1440

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Update librsvg to version 2.59.1 #1440

wants to merge 2 commits into from

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Sep 18, 2024

librsvg updated the build system to meson. This is a draft PR until we resolve issues related to building librsvg with the latest Cargo.

@pbor
Copy link
Contributor

pbor commented Sep 18, 2024

It is not clear to me if it is the same issue or an additional one, but there is also a compatibility issue with meson 1.5 https://gitlab.gnome.org/GNOME/librsvg/-/issues/1099

@danyeaw
Copy link
Member Author

danyeaw commented Sep 22, 2024

Upstream Rust issue: rust-lang/rust#129020

@pbor
Copy link
Contributor

pbor commented Sep 22, 2024

If that is accurate, the fix should be in Rust 1.82.0, which is scheduled on Oct 17

@fanc999-1
Copy link

It is not clear to me if it is the same issue or an additional one, but there is also a compatibility issue with meson 1.5 https://gitlab.gnome.org/GNOME/librsvg/-/issues/1099

No, it's an additional one that actually hits HarfBuzz, not librsvg. I checked with 1.5.1, and things worked there.

@pbor
Copy link
Contributor

pbor commented Sep 26, 2024

It is not clear to me if it is the same issue or an additional one, but there is also a compatibility issue with meson 1.5 https://gitlab.gnome.org/GNOME/librsvg/-/issues/1099

No, it's an additional one that actually hits HarfBuzz, not librsvg. I checked with 1.5.1, and things worked there.

Ok, but if I read it correctly that only affects meson subprojects so it should not affect us

@danyeaw danyeaw changed the title Update librsvg to version 2.59.0 Update librsvg to version 2.59.1 Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants