Add GTK3 to release artifacts #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyeaw
force-pushed
the
release-gtk3
branch
from
8bbb4f0
to
abbdc3c
Compare
|
I am not opposed to this and I do not personally use the release artifacts used by our CI, however having everything in a single archive seems a bit weird: as a user how do I avoid shipping an unneeded version of gtk with my application? having to manually remove some of the dlls seems not great. |
|
Hi @pbor, thanks for the feedback. There are two separate zip archives, one for GTK3 and one for GTK4. |
Ah ok. I could not tell from just looking at the diff, sorry. Then sure, let's merge this. |
pbor
approved these changes
Oct 1, 2024
|
\o/ thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1412 by adding release binaries for GTK3.