Upload GTK runtime zip after build #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyeaw
force-pushed
the
upload-gtk-runtime
branch
from
c622c31
to
cdf42d2
Compare
pbor
reviewed
Jul 3, 2023
danyeaw
force-pushed
the
upload-gtk-runtime
branch
from
cdf42d2
to
c3bc456
Compare
|
I do not have a strong opinion... I am just a bit concerned about the level of support expected. I think we need to make it super clear in the README that these binaries come with NO guarantees and no expectations about timely security updates or things like that. |
|
@pbor I added a statement that the binaries are provided as-is. What do you think? |
pbor
reviewed
Feb 5, 2024
danyeaw
force-pushed
the
upload-gtk-runtime
branch
from
74b8262
to
0b2a2de
Compare
pbor
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #145 by zipping up the built runtime and uploading it.